Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ranger: BuildColumnRange should merge ranges when column has prefix len (#11563) #11565

Merged
merged 4 commits into from
Aug 5, 2019
Merged

ranger: BuildColumnRange should merge ranges when column has prefix len (#11563) #11565

merged 4 commits into from
Aug 5, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 1, 2019

cherry-pick #11563 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 1, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Aug 1, 2019
Merged
@bb7133
Copy link
Member

bb7133 commented Aug 5, 2019

/run-unit-test

zz-jason
zz-jason reviewed Aug 5, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from eurekaka August 5, 2019 08:04
@bb7133
Copy link
Member

bb7133 commented Aug 5, 2019

/run-unit-test

@zz-jason zz-jason added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Aug 5, 2019
@zz-jason zz-jason requested a review from alivxxx August 5, 2019 09:16
@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Aug 5, 2019
alivxxx
alivxxx approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2019
@zz-jason zz-jason merged commit 7d1e3e7 into pingcap:release-3.0 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@alivxxx alivxxx alivxxx approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @bb7133 @zz-jason @alivxxx @winoros